Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 6825055: Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. (Closed)

Created:
9 years, 8 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81303

Patch Set 1 #

Patch Set 2 : rebase to ToT #

Patch Set 3 : fix ui/base/ #

Total comments: 2

Patch Set 4 : revert bad indentation, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -468 lines) Patch
D base/scoped_comptr_win.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 14 chunks +29 lines, -23 lines 0 comments Download
M chrome/browser/accessibility/browser_accessibility_manager_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/accessibility/browser_accessibility_win_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/accessibility/browser_views_accessibility_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/aeropeek_manager.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_accessibility.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tts_api_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google/google_update.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/history_publisher.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/history/history_publisher_win.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/platform_util_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/shell_dialogs_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/win_safe_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 6 chunks +7 lines, -10 lines 0 comments Download
M chrome_frame/bho.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/bho.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M chrome_frame/bind_context_info.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/bind_context_info.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/bind_status_callback_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/bind_status_callback_impl.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/buggy_bho_handling.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/chrome_active_document.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 22 chunks +27 lines, -27 lines 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 18 chunks +21 lines, -21 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/com_message_event.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome_frame/com_message_event.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/com_type_info_holder.h View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/com_type_info_holder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/external_tab.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome_frame/http_negotiate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/http_negotiate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/in_place_menu.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/plugin_url_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/protocol_sink_wrap.cc View 21 chunks +25 lines, -24 lines 0 comments Download
M chrome_frame/stream_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome_frame/test/com_message_event_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/test/ie_event_sink.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 1 10 chunks +14 lines, -14 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/test/navigation_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/perf/silverlight.cc View 1 2 3 3 chunks +6 lines, -4 lines 0 comments Download
M chrome_frame/test/reliability/page_load_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/urlmon_moniker_integration_test.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome_frame/test/urlmon_moniker_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/urlmon_bind_status_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/urlmon_bind_status_callback.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_moniker.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M chrome_frame/urlmon_upload_data_stream_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome_frame/urlmon_url_request_private.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome_frame/utils.cc View 12 chunks +13 lines, -14 lines 0 comments Download
M content/common/gpu/media/mft_angle_video_device.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/tools/mfdecoder/main.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M media/tools/mfdecoder/mfdecoder.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M media/video/mft_h264_decode_engine.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/video/mft_h264_decode_engine.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M net/http/url_security_manager_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M printing/backend/print_backend_win.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_win_unittest.cc View 1 2 7 chunks +8 lines, -8 lines 0 comments Download
M ui/gfx/canvas_direct2d.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/canvas_direct2d.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M ui/gfx/canvas_direct2d_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
9 years, 8 months ago (2011-04-11 23:15:26 UTC) #1
brettw
LGTM http://codereview.chromium.org/6825055/diff/4001/chrome_frame/test/perf/silverlight.cc File chrome_frame/test/perf/silverlight.cc (right): http://codereview.chromium.org/6825055/diff/4001/chrome_frame/test/perf/silverlight.cc#newcode76 chrome_frame/test/perf/silverlight.cc:76: class SilverlightContainer : public IServiceProviderImpl<SilverlightContainer>, I think the ...
9 years, 8 months ago (2011-04-12 19:53:49 UTC) #2
tfarina
9 years, 8 months ago (2011-04-12 20:06:51 UTC) #3
http://codereview.chromium.org/6825055/diff/4001/chrome_frame/test/perf/silve...
File chrome_frame/test/perf/silverlight.cc (right):

http://codereview.chromium.org/6825055/diff/4001/chrome_frame/test/perf/silve...
chrome_frame/test/perf/silverlight.cc:76: class SilverlightContainer : public
IServiceProviderImpl<SilverlightContainer>,
On 2011/04/12 19:53:49, brettw wrote:
> I think the old indenting was better here.

Reverted this change. Lint just complained, so I tried to fix. But I agree the
old indentation is better.

Powered by Google App Engine
This is Rietveld 408576698