Issue 6794021: Get rid of PrefService::GetMutableDictionary/GetMutableList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6794021: Get rid of PrefService::GetMutableDictionary/GetMutableList (Closed)

Created:
9 years, 8 months ago by battre

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Get rid of PrefService::GetMutableDictionary/GetMutableList BUG=77914 TEST=none, trybots remain green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80455

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -26 lines)			Patch
	M	chrome/browser/ui/webui/most_visited_handler.h	View		3 chunks	+9 lines, -12 lines	0 comments	Download
	M	chrome/browser/ui/webui/most_visited_handler.cc	View		5 chunks	+16 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

battre

Hi. It has been quite some time but I think you are the original author ...

9 years, 8 months ago (2011-04-04 16:55:45 UTC) #1

tony

9 years, 8 months ago (2011-04-04 17:54:37 UTC) #2

I wasn't the original author of this code, but LGTM.

BTW, I'm not sure how much it buys you to make PrefService::GetDictionary and
PrefService::GetList const since both allow you to call GetDictionary/GetList to
get mutable sub-trees.

Expand Messages | Collapse Messages