Get rid of PrefService::GetMutableDictionary/GetMutableList

chrome/browser/ui/webui/most_visited_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_MOST_VISITED_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_MOST_VISITED_HANDLER_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "chrome/browser/history/history_types.h"
 #include "content/browser/cancelable_request.h"
 #include "content/browser/webui/web_ui.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 
-class DictionaryValue;
 class GURL;
 class ListValue;
 class PageUsageData;
 class PrefService;
 class Value;
 
 // The handler for Javascript messages related to the "most visited" view.
+//
+// This class manages two preferences:
+// - The URL blacklist: URLs we do not want to show in the thumbnails list.  It
+//   is a dictionary for quick access (it associates a dummy boolean to the URL
+//   string).
+// - Pinned URLs: This is a dictionary for the pinned URLs for the the most
+//   visited part of the new tab page. The key of the dictionary is a hash of
+//   the URL and the value is a dictionary with title, url and index.  This is
+//   owned by the PrefService.
 class MostVisitedHandler : public WebUIMessageHandler,
                            public NotificationObserver {
  public:
 
   MostVisitedHandler();
   virtual ~MostVisitedHandler();
 
   // WebUIMessageHandler override and implementation.
   virtual WebUIMessageHandler* Attach(WebUI* web_ui);
   virtual void RegisterMessages();
@@ skipping 69 matching lines @@
 
   // Our consumer for the history service.
   CancelableRequestConsumerTSimple<PageUsageData*> cancelable_consumer_;
   CancelableRequestConsumer topsites_consumer_;
 
   // The most visited URLs, in priority order.
   // Only used for matching up clicks on the page to which most visited entry
   // was clicked on for metrics purposes.
   std::vector<GURL> most_visited_urls_;
 
-  // The URL blacklist: URLs we do not want to show in the thumbnails list.  It
-  // is a dictionary for quick access (it associates a dummy boolean to the URL
-  // string).  This is owned by the PrefService.
-  DictionaryValue* url_blacklist_;
-
-  // This is a dictionary for the pinned URLs for the the most visited part of
-  // the new tab page. The key of the dictionary is a hash of the URL and the
-  // value is a dictionary with title, url and index.  This is owned by the
-  // PrefService.
-  DictionaryValue* pinned_urls_;
-
   // We pre-fetch the first set of result pages.  This variable is false until
   // we get the first getMostVisited() call.
   bool got_first_most_visited_request_;
 
   // Keep the results of the db query here.
   scoped_ptr<ListValue> pages_value_;
 
   DISALLOW_COPY_AND_ASSIGN(MostVisitedHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_MOST_VISITED_HANDLER_H_