Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4494)

Unified Diff: chrome/browser/ui/webui/most_visited_handler.h

Issue 6794021: Get rid of PrefService::GetMutableDictionary/GetMutableList (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/most_visited_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/most_visited_handler.h
diff --git a/chrome/browser/ui/webui/most_visited_handler.h b/chrome/browser/ui/webui/most_visited_handler.h
index c2a53ee8c63cbec3ff5512b8cfbcdd22dffda4ee..d9e1fc4c443e9b3f75379ab6878c7df44ac356e0 100644
--- a/chrome/browser/ui/webui/most_visited_handler.h
+++ b/chrome/browser/ui/webui/most_visited_handler.h
@@ -15,7 +15,6 @@
#include "content/common/notification_observer.h"
#include "content/common/notification_registrar.h"
-class DictionaryValue;
class GURL;
class ListValue;
class PageUsageData;
@@ -23,6 +22,15 @@ class PrefService;
class Value;
// The handler for Javascript messages related to the "most visited" view.
+//
+// This class manages two preferences:
+// - The URL blacklist: URLs we do not want to show in the thumbnails list. It
+// is a dictionary for quick access (it associates a dummy boolean to the URL
+// string).
+// - Pinned URLs: This is a dictionary for the pinned URLs for the the most
+// visited part of the new tab page. The key of the dictionary is a hash of
+// the URL and the value is a dictionary with title, url and index. This is
+// owned by the PrefService.
class MostVisitedHandler : public WebUIMessageHandler,
public NotificationObserver {
public:
@@ -112,17 +120,6 @@ class MostVisitedHandler : public WebUIMessageHandler,
// was clicked on for metrics purposes.
std::vector<GURL> most_visited_urls_;
- // The URL blacklist: URLs we do not want to show in the thumbnails list. It
- // is a dictionary for quick access (it associates a dummy boolean to the URL
- // string). This is owned by the PrefService.
- DictionaryValue* url_blacklist_;
-
- // This is a dictionary for the pinned URLs for the the most visited part of
- // the new tab page. The key of the dictionary is a hash of the URL and the
- // value is a dictionary with title, url and index. This is owned by the
- // PrefService.
- DictionaryValue* pinned_urls_;
-
// We pre-fetch the first set of result pages. This variable is false until
// we get the first getMostVisited() call.
bool got_first_most_visited_request_;
« no previous file with comments | « no previous file | chrome/browser/ui/webui/most_visited_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698