Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 6730052: Use chromeos::Process in libchromeos.a instead of g_spawn_async. (Closed)

Created:
9 years, 9 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Use chromeos::Process in libchromeos.a instead of g_spawn_async. Change the order of -l linker flags in SConstruct.chromiumos since libchromeos.a depends on libbase. Without the change, chrome fails to dlopen libcros.so. BUG=chromium-os:12875 TEST=1) ran 'FEATURES=test emerge-x86-generic libcros' to see the library link order is correct. 2) manually checked the new code could change the layout correctly. Change-Id: I77ea179f93fac368b76fe596db32d349911993ac Review URL: http://codereview.chromium.org/6709058 (cherry picked from commit 1167c711c1fd411cc5437c2aab7f64d948be7f6b) Use g_spawn_async instead of _sync to avoid blocking UI-thread. This change does the following as well: * Deprecate getter APIs that are currently unused. * Stop calling 'setxkbmap -print'. Instead, just remember the last layout and modifier mappings set. BUG=chromium-os:13029 TEST=1) manually checked 2) ran the unittest Change-Id: If141b273c5ed455b34ae41c75f9f0e1729163e69 Review URL: http://codereview.chromium.org/6691007 (cherry picked from commit 7688b1249dba6d8ce129e220c2977845666a1aaf) TBR=satorux Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fcede59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -353 lines) Patch
M SConstruct.chromiumos View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos_keyboard.h View 1 chunk +1 line, -25 lines 0 comments Download
M chromeos_keyboard.cc View 11 chunks +60 lines, -238 lines 0 comments Download
M chromeos_keyboard_unittest.cc View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Yusuke Sato
9 years, 9 months ago (2011-03-25 09:51:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698