Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 6709058: Use chromeos::Process in libchromeos.a instead of g_spawn_async. (Closed)

Created:
9 years, 9 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-os-reviews_chromium.org, Zachary Kuznia
Visibility:
Public.

Description

Use chromeos::Process in libchromeos.a instead of g_spawn_async. Change the order of -l linker flags in SConstruct.chromiumos since libchromeos.a depends on libbase. Without the change, chrome fails to dlopen libcros.so. BUG=chromium-os:12875 TEST=1) ran 'FEATURES=test emerge-x86-generic libcros' to see the library link order is correct. 2) manually checked the new code could change the layout correctly. Change-Id: I77ea179f93fac368b76fe596db32d349911993ac Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1167c71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M SConstruct.chromiumos View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos_keyboard.cc View 2 chunks +17 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
This change is similar to http://codereview.chromium.org/6714044/. For libcros, we can use the chromeos::Process class in ...
9 years, 9 months ago (2011-03-21 11:45:39 UTC) #1
satorux1
What about moving chromeos_keyboard.cc to Chrome and use base/process_utils.h ?
9 years, 9 months ago (2011-03-21 11:52:59 UTC) #2
Yusuke Sato
This change is for R11. Moving it to Chrome would make it hard to merge ...
9 years, 9 months ago (2011-03-21 11:54:47 UTC) #3
satorux1
9 years, 9 months ago (2011-03-21 12:03:31 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698