Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 6691007: Use g_spawn_async instead of _sync. (Closed)

Created:
9 years, 9 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-os-reviews_chromium.org, Zachary Kuznia, Daniel Erat
Visibility:
Public.

Description

Use g_spawn_async instead of _sync to avoid blocking UI-thread. This change does the following as well: * Deprecate getter APIs that are currently unused. * Stop calling 'setxkbmap -print'. Instead, just remember the last layout and modifier mappings set. BUG=chromium-os:13029 TEST=1) manually checked 2) ran the unittest Change-Id: If141b273c5ed455b34ae41c75f9f0e1729163e69 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7688b12

Patch Set 1 : review #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -340 lines) Patch
M chromeos_keyboard.h View 1 chunk +1 line, -25 lines 0 comments Download
M chromeos_keyboard.cc View 1 11 chunks +57 lines, -227 lines 0 comments Download
M chromeos_keyboard_unittest.cc View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
9 years, 9 months ago (2011-03-14 10:35:49 UTC) #1
Yusuke Sato
As you know, changing g_spawn_sync to _async might not be perfect due to http://crosbug.com/12875, but ...
9 years, 9 months ago (2011-03-14 11:08:47 UTC) #2
Daniel Erat
nit: typo in the description; 13209 should be 13029 On Mon, Mar 14, 2011 at ...
9 years, 9 months ago (2011-03-14 16:10:12 UTC) #3
Yusuke Sato
On 2011/03/14 16:10:12, Daniel Erat wrote: > nit: typo in the description; 13209 should be ...
9 years, 9 months ago (2011-03-14 16:14:06 UTC) #4
satorux1
LGTM, but the change does much more than what the description says. Please update the ...
9 years, 9 months ago (2011-03-14 20:52:33 UTC) #5
Yusuke Sato
9 years, 9 months ago (2011-03-15 03:09:41 UTC) #6
http://codereview.chromium.org/6691007/diff/1004/chromeos_keyboard.cc
File chromeos_keyboard.cc (right):

http://codereview.chromium.org/6691007/diff/1004/chromeos_keyboard.cc#newcode25
chromeos_keyboard.cc:25: // TODO(yusukes): Use libxkbfile.so instead of the
command.
On 2011/03/14 20:52:33, satorux1 wrote:
> Please file a bug and add a link to it.

Done.

Powered by Google App Engine
This is Rietveld 408576698