Move a bunch of renderer->browser messages to content.

Move a bunch of renderer->browser messages to content.

TBR=tsepez
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79152

[Tom Sepez, 2011-03-23 17:32:53]

http://codereview.chromium.org/6721021/diff/3044/chrome/browser/accessibility...
File chrome/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/6721021/diff/3044/chrome/browser/accessibility...
chrome/browser/accessibility/browser_accessibility_cocoa.mm:130: return
NSMakePoint(browserAccessibility_->location().x(),
Maybe change gfx::rect to make the underlying member public so we can write
serialization macros for it?

http://codereview.chromium.org/6721021/diff/3044/chrome/common/common_param_t...
File chrome/common/common_param_traits.cc (right):

http://codereview.chromium.org/6721021/diff/3044/chrome/common/common_param_t...
chrome/common/common_param_traits.cc:151: void
ParamTraits<printing::PageRange>::Write(Message* m, const param_type& p) {
Can these be macrofied?

http://codereview.chromium.org/6721021/diff/3044/chrome/common/common_param_t...
File chrome/common/common_param_traits.h (left):

http://codereview.chromium.org/6721021/diff/3044/chrome/common/common_param_t...
chrome/common/common_param_traits.h:26: // TODO(erg): The following headers are
historical and only work because
Does the warning still apply?  Don't add ANY webkit dependencies (rather than
new ones).

http://codereview.chromium.org/6721021/diff/3044/chrome/common/render_message...
File chrome/common/render_messages_params.cc (right):

http://codereview.chromium.org/6721021/diff/3044/chrome/common/render_message...
chrome/common/render_messages_params.cc:329: WriteParam(m, p.page_size);
Can these be macro-ized?

http://codereview.chromium.org/6721021/diff/3044/chrome/renderer/chrome_conte...
File chrome/renderer/chrome_content_renderer_client.cc (right):

http://codereview.chromium.org/6721021/diff/3044/chrome/renderer/chrome_conte...
chrome/renderer/chrome_content_renderer_client.cc:57: int plugin_setting =
CONTENT_SETTING_DEFAULT;
sizeof(int) != sizeof(enum) if -fshort-enums?  Did we change
ViewHostMsg_GetPluginInfo() constructor to take an int * as well?

http://codereview.chromium.org/6721021/diff/3044/content/common/common_param_...
File content/common/common_param_traits.cc (right):

http://codereview.chromium.org/6721021/diff/3044/content/common/common_param_...
content/common/common_param_traits.cc:841: const param_type& p) {
Can this be macro-ized?

http://codereview.chromium.org/6721021/diff/3044/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/6721021/diff/3044/content/renderer/render_view...
content/renderer/render_view.cc:919: routing_id_, params.url,
frame->top()->url(), params.mimeType.utf8(),
Constructor now expecting an int* not a ContentSetting* ?

[jam, 2011-03-23 18:21:02]

http://codereview.chromium.org/6721021/diff/3044/chrome/browser/accessibility...
File chrome/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/6721021/diff/3044/chrome/browser/accessibility...
chrome/browser/accessibility/browser_accessibility_cocoa.mm:130: return
NSMakePoint(browserAccessibility_->location().x(),
On 2011/03/23 17:32:53, Tom Sepez wrote:
> Maybe change gfx::rect to make the underlying member public so we can write
> serialization macros for it?

We couldn't do that since that would go against the Google C++ style guide
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Structs_vs._Cl...)

http://codereview.chromium.org/6721021/diff/3044/chrome/common/common_param_t...
File chrome/common/common_param_traits.cc (right):

http://codereview.chromium.org/6721021/diff/3044/chrome/common/common_param_t...
chrome/common/common_param_traits.cc:151: void
ParamTraits<printing::PageRange>::Write(Message* m, const param_type& p) {
On 2011/03/23 17:32:53, Tom Sepez wrote:
> Can these be macrofied?

yep, i was only doing stuff for now that is moving to content.  once i'm done
moving all the messages, then there'll be few left and we can switch them in one
go

http://codereview.chromium.org/6721021/diff/3044/chrome/common/common_param_t...
File chrome/common/common_param_traits.h (left):

http://codereview.chromium.org/6721021/diff/3044/chrome/common/common_param_t...
chrome/common/common_param_traits.h:26: // TODO(erg): The following headers are
historical and only work because
On 2011/03/23 17:32:53, Tom Sepez wrote:
> Does the warning still apply?  Don't add ANY webkit dependencies (rather than
> new ones).

not anymore, since this file isn't used by the nacl 64 dll anymore.  this issue
will be fixed with work that bradnelson is doing to automatically generate 64
bit targets.  and also, now we have a buildbot for this target, as opposed to
before.  try bot errors are a lot better than warnings :)

http://codereview.chromium.org/6721021/diff/3044/chrome/renderer/chrome_conte...
File chrome/renderer/chrome_content_renderer_client.cc (right):

http://codereview.chromium.org/6721021/diff/3044/chrome/renderer/chrome_conte...
chrome/renderer/chrome_content_renderer_client.cc:57: int plugin_setting =
CONTENT_SETTING_DEFAULT;
On 2011/03/23 17:32:53, Tom Sepez wrote:
> sizeof(int) != sizeof(enum) if -fshort-enums?  Did we change
> ViewHostMsg_GetPluginInfo() constructor to take an int * as well?

yeah, temporarily since i wanted to move this file, but i didn't want to move
the contentsetting enum which is chrome specific.  i have a todo to refactor
this code

http://codereview.chromium.org/6721021/diff/3044/content/common/common_param_...
File content/common/common_param_traits.cc (right):

http://codereview.chromium.org/6721021/diff/3044/content/common/common_param_...
content/common/common_param_traits.cc:841: const param_type& p) {
On 2011/03/23 17:32:53, Tom Sepez wrote:
> Can this be macro-ized?

the problem is that this is used by another file,
chrome/common/autofill_messages.h.  i think what we need is another file for
common param traits that is included by content_message_generator.

[Tom Sepez, 2011-03-23 18:25:26]

LGTM.