Move a bunch of renderer->browser messages to content.

chrome/common/common_param_traits.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/common_param_traits.h"
 
 #include "base/time.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/thumbnail_score.h"
 #include "chrome/common/web_apps.h"
 #include "content/common/common_param_traits.h"
 #include "googleurl/src/gurl.h"
 #include "printing/backend/print_backend.h"
 #include "printing/native_metafile.h"
 #include "printing/page_range.h"
-#include "webkit/glue/password_form.h"
 
 namespace IPC {
 
 void ParamTraits<ContentSetting>::Write(Message* m, const param_type& p) {
   WriteParam(m, static_cast<int>(p));
 }
 
 bool ParamTraits<ContentSetting>::Read(const Message* m, void** iter,
                                        param_type* r) {
   int value;
@@ skipping 114 matching lines @@
   r->at_top = at_top;
   r->time_at_snapshot = time_at_snapshot;
   return true;
 }
 
 void ParamTraits<ThumbnailScore>::Log(const param_type& p, std::string* l) {
   l->append(base::StringPrintf("(%f, %d, %d)",
                                p.boring_score, p.good_clipping, p.at_top));
 }
 
-void ParamTraits<webkit_glue::PasswordForm>::Write(Message* m,
-                                                   const param_type& p) {
-  WriteParam(m, p.signon_realm);
-  WriteParam(m, p.origin);
-  WriteParam(m, p.action);
-  WriteParam(m, p.submit_element);
-  WriteParam(m, p.username_element);
-  WriteParam(m, p.username_value);
-  WriteParam(m, p.password_element);
-  WriteParam(m, p.password_value);
-  WriteParam(m, p.old_password_element);
-  WriteParam(m, p.old_password_value);
-  WriteParam(m, p.ssl_valid);
-  WriteParam(m, p.preferred);
-  WriteParam(m, p.blacklisted_by_user);
-}
-
-bool ParamTraits<webkit_glue::PasswordForm>::Read(const Message* m, void** iter,
-                                                  param_type* p) {
-  return
-      ReadParam(m, iter, &p->signon_realm) &&
-      ReadParam(m, iter, &p->origin) &&
-      ReadParam(m, iter, &p->action) &&
-      ReadParam(m, iter, &p->submit_element) &&
-      ReadParam(m, iter, &p->username_element) &&
-      ReadParam(m, iter, &p->username_value) &&
-      ReadParam(m, iter, &p->password_element) &&
-      ReadParam(m, iter, &p->password_value) &&
-      ReadParam(m, iter, &p->old_password_element) &&
-      ReadParam(m, iter, &p->old_password_value) &&
-      ReadParam(m, iter, &p->ssl_valid) &&
-      ReadParam(m, iter, &p->preferred) &&
-      ReadParam(m, iter, &p->blacklisted_by_user);
-}
-void ParamTraits<webkit_glue::PasswordForm>::Log(const param_type& p,
-                                                 std::string* l) {
-  l->append("<PasswordForm>");
-}
-
 void ParamTraits<printing::PageRange>::Write(Message* m, const param_type& p) {

[Tom Sepez, 2011/03/23 17:32:53]

Can these be macrofied?

[jam, 2011/03/23 18:21:02]

yep, i was only doing stuff for now that is moving to content.  once i'm done
moving all the messages, then there'll be few left and we can switch them in one
go

   WriteParam(m, p.from);
   WriteParam(m, p.to);
 }
 
 bool ParamTraits<printing::PageRange>::Read(
     const Message* m, void** iter, param_type* p) {
   return ReadParam(m, iter, &p->from) &&
          ReadParam(m, iter, &p->to);
 }
 
@@ skipping 53 matching lines @@
   l->append(",");
   LogParam(p.caps_mime_type, l);
   l->append(",");
   LogParam(p.printer_defaults, l);
   l->append(",");
   LogParam(p.defaults_mime_type, l);
   l->append(")");
 }
 
 }  // namespace IPC