Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5765)

Unified Diff: chrome/common/common_param_traits.h

Issue 6721021: Move a bunch of renderer->browser messages to content. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/common_param_traits.h
===================================================================
--- chrome/common/common_param_traits.h (revision 79131)
+++ chrome/common/common_param_traits.h (working copy)
@@ -17,15 +17,6 @@
#include "chrome/common/content_settings.h"
#include "ipc/ipc_message_utils.h"
#include "printing/native_metafile.h"
-// !!! WARNING: DO NOT ADD NEW WEBKIT DEPENDENCIES !!!
-//
-// That means don't add #includes to any file in 'webkit/' or
-// 'third_party/WebKit/'. Chrome Frame and NACL build parts of base/ and
-// chrome/common/ for a mini-library that doesn't depend on webkit.
-//
-// TODO(erg): The following headers are historical and only work because
Tom Sepez 2011/03/23 17:32:53 Does the warning still apply? Don't add ANY webki
jam 2011/03/23 18:21:02 not anymore, since this file isn't used by the nac
-// their definitions are inlined, which also needs to be fixed.
-#include "webkit/glue/window_open_disposition.h"
// Forward declarations.
class DictionaryValue;
@@ -38,10 +29,6 @@
struct PrinterCapsAndDefaults;
} // namespace printing
-namespace webkit_glue {
-struct PasswordForm;
-} // namespace webkit_glue
-
namespace IPC {
template <>
@@ -81,24 +68,6 @@
};
template <>
-struct ParamTraits<WindowOpenDisposition> {
- typedef WindowOpenDisposition param_type;
- static void Write(Message* m, const param_type& p) {
- WriteParam(m, static_cast<int>(p));
- }
- static bool Read(const Message* m, void** iter, param_type* r) {
- int value;
- if (!ReadParam(m, iter, &value))
- return false;
- *r = static_cast<param_type>(value);
- return true;
- }
- static void Log(const param_type& p, std::string* l) {
- LogParam(static_cast<int>(p), l);
- }
-};
-
-template <>
struct ParamTraits<WebApplicationInfo> {
typedef WebApplicationInfo param_type;
static void Write(Message* m, const param_type& p);
@@ -115,14 +84,6 @@
};
template <>
-struct ParamTraits<webkit_glue::PasswordForm> {
- typedef webkit_glue::PasswordForm param_type;
- static void Write(Message* m, const param_type& p);
- static bool Read(const Message* m, void** iter, param_type* p);
- static void Log(const param_type& p, std::string* l);
-};
-
-template <>
struct ParamTraits<printing::PageRange> {
typedef printing::PageRange param_type;
static void Write(Message* m, const param_type& p);

Powered by Google App Engine
This is Rietveld 408576698