Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1802)

Unified Diff: chrome/browser/ui/webui/extensions/pack_extension_handler.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/pack_extension_handler.h
diff --git a/chrome/browser/ui/webui/extensions/pack_extension_handler.h b/chrome/browser/ui/webui/extensions/pack_extension_handler.h
index fd5f5442bfcb701bc94fd7b971a7f8fb6677a3e4..36a27b38cb3d40a88141732f45077f75c928e5f7 100644
--- a/chrome/browser/ui/webui/extensions/pack_extension_handler.h
+++ b/chrome/browser/ui/webui/extensions/pack_extension_handler.h
@@ -26,27 +26,28 @@ class PackExtensionHandler : public content::WebUIMessageHandler,
public PackExtensionJob::Client {
public:
PackExtensionHandler();
- virtual ~PackExtensionHandler();
+ ~PackExtensionHandler() override;
void GetLocalizedValues(content::WebUIDataSource* source);
// WebUIMessageHandler implementation.
- virtual void RegisterMessages() override;
+ void RegisterMessages() override;
// ExtensionPackJob::Client implementation.
- virtual void OnPackSuccess(const base::FilePath& crx_file,
- const base::FilePath& key_file) override;
+ void OnPackSuccess(const base::FilePath& crx_file,
+ const base::FilePath& key_file) override;
- virtual void OnPackFailure(const std::string& error,
- ExtensionCreator::ErrorType) override;
+ void OnPackFailure(const std::string& error,
+ ExtensionCreator::ErrorType) override;
private:
// SelectFileDialog::Listener implementation.
- virtual void FileSelected(const base::FilePath& path,
- int index, void* params) override;
- virtual void MultiFilesSelected(
- const std::vector<base::FilePath>& files, void* params) override;
- virtual void FileSelectionCanceled(void* params) override {}
+ void FileSelected(const base::FilePath& path,
+ int index,
+ void* params) override;
+ void MultiFilesSelected(const std::vector<base::FilePath>& files,
+ void* params) override;
+ void FileSelectionCanceled(void* params) override {}
// JavaScript callback to start packing an extension.
void HandlePackMessage(const base::ListValue* args);

Powered by Google App Engine
This is Rietveld 408576698