Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/ui/webui/extensions/pack_extension_handler.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_PACK_EXTENSION_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_PACK_EXTENSION_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_PACK_EXTENSION_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_PACK_EXTENSION_HANDLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "chrome/browser/browsing_data/browsing_data_remover.h" 11 #include "chrome/browser/browsing_data/browsing_data_remover.h"
12 #include "chrome/browser/extensions/pack_extension_job.h" 12 #include "chrome/browser/extensions/pack_extension_job.h"
13 #include "chrome/browser/plugins/plugin_data_remover_helper.h" 13 #include "chrome/browser/plugins/plugin_data_remover_helper.h"
14 #include "content/public/browser/web_ui_message_handler.h" 14 #include "content/public/browser/web_ui_message_handler.h"
15 #include "ui/shell_dialogs/select_file_dialog.h" 15 #include "ui/shell_dialogs/select_file_dialog.h"
16 16
17 namespace content { 17 namespace content {
18 class WebUIDataSource; 18 class WebUIDataSource;
19 } 19 }
20 20
21 namespace extensions { 21 namespace extensions {
22 22
23 // Clear browser data handler page UI handler. 23 // Clear browser data handler page UI handler.
24 class PackExtensionHandler : public content::WebUIMessageHandler, 24 class PackExtensionHandler : public content::WebUIMessageHandler,
25 public ui::SelectFileDialog::Listener, 25 public ui::SelectFileDialog::Listener,
26 public PackExtensionJob::Client { 26 public PackExtensionJob::Client {
27 public: 27 public:
28 PackExtensionHandler(); 28 PackExtensionHandler();
29 virtual ~PackExtensionHandler(); 29 ~PackExtensionHandler() override;
30 30
31 void GetLocalizedValues(content::WebUIDataSource* source); 31 void GetLocalizedValues(content::WebUIDataSource* source);
32 32
33 // WebUIMessageHandler implementation. 33 // WebUIMessageHandler implementation.
34 virtual void RegisterMessages() override; 34 void RegisterMessages() override;
35 35
36 // ExtensionPackJob::Client implementation. 36 // ExtensionPackJob::Client implementation.
37 virtual void OnPackSuccess(const base::FilePath& crx_file, 37 void OnPackSuccess(const base::FilePath& crx_file,
38 const base::FilePath& key_file) override; 38 const base::FilePath& key_file) override;
39 39
40 virtual void OnPackFailure(const std::string& error, 40 void OnPackFailure(const std::string& error,
41 ExtensionCreator::ErrorType) override; 41 ExtensionCreator::ErrorType) override;
42 42
43 private: 43 private:
44 // SelectFileDialog::Listener implementation. 44 // SelectFileDialog::Listener implementation.
45 virtual void FileSelected(const base::FilePath& path, 45 void FileSelected(const base::FilePath& path,
46 int index, void* params) override; 46 int index,
47 virtual void MultiFilesSelected( 47 void* params) override;
48 const std::vector<base::FilePath>& files, void* params) override; 48 void MultiFilesSelected(const std::vector<base::FilePath>& files,
49 virtual void FileSelectionCanceled(void* params) override {} 49 void* params) override;
50 void FileSelectionCanceled(void* params) override {}
50 51
51 // JavaScript callback to start packing an extension. 52 // JavaScript callback to start packing an extension.
52 void HandlePackMessage(const base::ListValue* args); 53 void HandlePackMessage(const base::ListValue* args);
53 54
54 // JavaScript callback to show a file browse dialog. 55 // JavaScript callback to show a file browse dialog.
55 // |args[0]| must be a string that specifies the file dialog type: file or 56 // |args[0]| must be a string that specifies the file dialog type: file or
56 // folder. 57 // folder.
57 // |args[1]| must be a string that specifies the operation to perform: load 58 // |args[1]| must be a string that specifies the operation to perform: load
58 // or pem. 59 // or pem.
59 void HandleSelectFilePathMessage(const base::ListValue* args); 60 void HandleSelectFilePathMessage(const base::ListValue* args);
(...skipping 16 matching lines...) Expand all
76 77
77 // Path to the last used folder to load an extension. 78 // Path to the last used folder to load an extension.
78 base::FilePath last_used_path_; 79 base::FilePath last_used_path_;
79 80
80 DISALLOW_COPY_AND_ASSIGN(PackExtensionHandler); 81 DISALLOW_COPY_AND_ASSIGN(PackExtensionHandler);
81 }; 82 };
82 83
83 } // namespace extensions 84 } // namespace extensions
84 85
85 #endif // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_PACK_EXTENSION_HANDLER_H_ 86 #endif // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_PACK_EXTENSION_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698