Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3136)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.h
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.h b/chrome/browser/ui/webui/extensions/extension_settings_handler.h
index 20cbc1de8758821d9d12d97e57a50a87399738e1..779a484f42e467c8d4c0aeaf9b80786b5c7a13f6 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.h
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.h
@@ -79,7 +79,7 @@ class ExtensionSettingsHandler
public base::SupportsWeakPtr<ExtensionSettingsHandler> {
public:
ExtensionSettingsHandler();
- virtual ~ExtensionSettingsHandler();
+ ~ExtensionSettingsHandler() override;
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
@@ -98,9 +98,8 @@ class ExtensionSettingsHandler
friend class BrokerDelegate;
// content::WebContentsObserver implementation.
- virtual void RenderViewDeleted(
- content::RenderViewHost* render_view_host) override;
- virtual void DidStartNavigationToPendingEntry(
+ void RenderViewDeleted(content::RenderViewHost* render_view_host) override;
+ void DidStartNavigationToPendingEntry(
const GURL& url,
content::NavigationController::ReloadType reload_type) override;
@@ -109,46 +108,44 @@ class ExtensionSettingsHandler
ManagementPolicy* policy);
// WebUIMessageHandler implementation.
- virtual void RegisterMessages() override;
+ void RegisterMessages() override;
// ErrorConsole::Observer implementation.
- virtual void OnErrorAdded(const ExtensionError* error) override;
+ void OnErrorAdded(const ExtensionError* error) override;
// content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// ExtensionRegistryObserver implementation.
- virtual void OnExtensionLoaded(content::BrowserContext* browser_context,
- const Extension* extension) override;
- virtual void OnExtensionUnloaded(
- content::BrowserContext* browser_context,
- const Extension* extension,
- UnloadedExtensionInfo::Reason reason) override;
- virtual void OnExtensionUninstalled(
- content::BrowserContext* browser_context,
- const Extension* extension,
- extensions::UninstallReason reason) override;
+ void OnExtensionLoaded(content::BrowserContext* browser_context,
+ const Extension* extension) override;
+ void OnExtensionUnloaded(content::BrowserContext* browser_context,
+ const Extension* extension,
+ UnloadedExtensionInfo::Reason reason) override;
+ void OnExtensionUninstalled(content::BrowserContext* browser_context,
+ const Extension* extension,
+ extensions::UninstallReason reason) override;
// ExtensionPrefsObserver implementation.
- virtual void OnExtensionDisableReasonsChanged(const std::string& extension_id,
- int disable_reasons) override;
+ void OnExtensionDisableReasonsChanged(const std::string& extension_id,
+ int disable_reasons) override;
// ExtensionManagement::Observer implementation.
- virtual void OnExtensionManagementSettingsChanged() override;
+ void OnExtensionManagementSettingsChanged() override;
// ExtensionUninstallDialog::Delegate implementation, used for receiving
// notification about uninstall confirmation dialog selections.
- virtual void ExtensionUninstallAccepted() override;
- virtual void ExtensionUninstallCanceled() override;
+ void ExtensionUninstallAccepted() override;
+ void ExtensionUninstallCanceled() override;
// WarningService::Observer implementation.
- virtual void ExtensionWarningsChanged() override;
+ void ExtensionWarningsChanged() override;
// ExtensionInstallPrompt::Delegate implementation.
- virtual void InstallUIProceed() override;
- virtual void InstallUIAbort(bool user_initiated) override;
+ void InstallUIProceed() override;
+ void InstallUIAbort(bool user_initiated) override;
// Called after the App Info Dialog has closed.
virtual void AppInfoDialogClosed();

Powered by Google App Engine
This is Rietveld 408576698