chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/extensions/extension_settings_browsertest.h ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc

index f267c852c6ddc6b6e75bb00cde471bd99c9387d9..ddc4facb9e598294327cd4bca3476738a8fd907d 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc

@@ -63,10 +63,9 @@ class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {

: ExtensionInstallPrompt(web_contents) {}

// Proceed without confirmation prompt.

- virtual void ConfirmInstall(

- Delegate* delegate,

- const Extension* extension,

- const ShowDialogCallback& show_dialog_callback) override {

+ void ConfirmInstall(Delegate* delegate,

+ const Extension* extension,

+ const ShowDialogCallback& show_dialog_callback) override {

delegate->InstallUIProceed();

}

};