Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2600)

Unified Diff: chrome/browser/ui/passwords/password_manager_presenter.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/password_manager_presenter.h
diff --git a/chrome/browser/ui/passwords/password_manager_presenter.h b/chrome/browser/ui/passwords/password_manager_presenter.h
index 4a27cc86d09d3f86332c316f9ad2762065503ce9..52523cf000bead5a576da0e5e6f6b0b4513952e5 100644
--- a/chrome/browser/ui/passwords/password_manager_presenter.h
+++ b/chrome/browser/ui/passwords/password_manager_presenter.h
@@ -29,10 +29,10 @@ class PasswordManagerPresenter
public:
// |password_view| the UI view that owns this presenter, must not be NULL.
explicit PasswordManagerPresenter(PasswordUIView* password_view);
- virtual ~PasswordManagerPresenter();
+ ~PasswordManagerPresenter() override;
// PasswordStore::Observer implementation.
- virtual void OnLoginsChanged(
+ void OnLoginsChanged(
const password_manager::PasswordStoreChangeList& changes) override;
// Repopulates the password and exception entries.
@@ -76,7 +76,7 @@ class PasswordManagerPresenter
class ListPopulater : public password_manager::PasswordStoreConsumer {
public:
explicit ListPopulater(PasswordManagerPresenter* page);
- virtual ~ListPopulater();
+ ~ListPopulater() override;
// Send a query to the password store to populate a list.
virtual void Populate() = 0;
@@ -91,10 +91,10 @@ class PasswordManagerPresenter
explicit PasswordListPopulater(PasswordManagerPresenter* page);
// Send a query to the password store to populate a password list.
- virtual void Populate() override;
+ void Populate() override;
// Send the password store's reply back to the handler.
- virtual void OnGetPasswordStoreResults(
+ void OnGetPasswordStoreResults(
const std::vector<autofill::PasswordForm*>& results) override;
};
@@ -104,10 +104,10 @@ class PasswordManagerPresenter
explicit PasswordExceptionListPopulater(PasswordManagerPresenter* page);
// Send a query to the password store to populate a passwordException list.
- virtual void Populate() override;
+ void Populate() override;
// Send the password store's reply back to the handler.
- virtual void OnGetPasswordStoreResults(
+ void OnGetPasswordStoreResults(
const std::vector<autofill::PasswordForm*>& results) override;
};

Powered by Google App Engine
This is Rietveld 408576698