chrome/browser/ui/passwords/save_password_refusal_combobox_model.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/save_password_refusal_combobox_model.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/passwords/password_manager_presenter.h ('k') | chrome/browser/ui/prefs/prefs_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/save_password_refusal_combobox_model.h

diff --git a/chrome/browser/ui/passwords/save_password_refusal_combobox_model.h b/chrome/browser/ui/passwords/save_password_refusal_combobox_model.h

index 5314cf2afe0375916d6269df5c1da211559d73d2..6a928780fe980fc73366d4085a0293774cce4f82 100644

--- a/chrome/browser/ui/passwords/save_password_refusal_combobox_model.h

+++ b/chrome/browser/ui/passwords/save_password_refusal_combobox_model.h

@@ -15,14 +15,14 @@ class SavePasswordRefusalComboboxModel : public ui::ComboboxModel {

enum { INDEX_NOPE = 0, INDEX_NEVER_FOR_THIS_SITE = 1 };

SavePasswordRefusalComboboxModel();

- virtual ~SavePasswordRefusalComboboxModel();

+ ~SavePasswordRefusalComboboxModel() override;

private:

// Overridden from ui::ComboboxModel:

- virtual int GetItemCount() const override;

- virtual base::string16 GetItemAt(int index) override;

- virtual bool IsItemSeparatorAt(int index) override;

- virtual int GetDefaultIndex() const override;

+ int GetItemCount() const override;

+ base::string16 GetItemAt(int index) override;

+ bool IsItemSeparatorAt(int index) override;

+ int GetDefaultIndex() const override;

std::vector<base::string16> items_;