Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2984)

Unified Diff: chrome/browser/ui/webui/options/options_ui.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/options_ui.h
diff --git a/chrome/browser/ui/webui/options/options_ui.h b/chrome/browser/ui/webui/options/options_ui.h
index c4b0f8476b6b94cfcd1a005cdddb58843a00a449..b14a89d6d281eb6ca64ce82084f75c02d8854f6c 100644
--- a/chrome/browser/ui/webui/options/options_ui.h
+++ b/chrome/browser/ui/webui/options/options_ui.h
@@ -42,7 +42,7 @@ class OptionsPageUIHandler : public content::WebUIMessageHandler {
static const char kSettingsAppKey[];
OptionsPageUIHandler();
- virtual ~OptionsPageUIHandler();
+ ~OptionsPageUIHandler() override;
// Is this handler enabled?
virtual bool IsEnabled();
@@ -66,7 +66,7 @@ class OptionsPageUIHandler : public content::WebUIMessageHandler {
virtual void Uninitialize() {}
// WebUIMessageHandler implementation.
- virtual void RegisterMessages() override {}
+ void RegisterMessages() override {}
protected:
struct OptionsStringResource {
@@ -115,7 +115,7 @@ class OptionsUI : public content::WebUIController,
typedef base::CallbackList<void()> OnFinishedLoadingCallbackList;
explicit OptionsUI(content::WebUI* web_ui);
- virtual ~OptionsUI();
+ ~OptionsUI() override;
// Registers a callback to be called once the settings frame has finished
// loading on the HTML/JS side.
@@ -132,15 +132,15 @@ class OptionsUI : public content::WebUIController,
ui::ScaleFactor scale_factor);
// Overridden from content::WebContentsObserver:
- virtual void DidStartProvisionalLoadForFrame(
+ void DidStartProvisionalLoadForFrame(
content::RenderFrameHost* render_frame_host,
const GURL& validated_url,
bool is_error_page,
bool is_iframe_srcdoc) override;
// Overridden from OptionsPageUIHandlerHost:
- virtual void InitializeHandlers() override;
- virtual void OnFinishedLoading() override;
+ void InitializeHandlers() override;
+ void OnFinishedLoading() override;
private:
// Adds OptionsPageUiHandler to the handlers list if handler is enabled.

Powered by Google App Engine
This is Rietveld 408576698