chrome/browser/ui/webui/options/options_ui.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_ui.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/options/options_ui.h ('k') | chrome/browser/ui/webui/options/options_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/options_ui.cc

diff --git a/chrome/browser/ui/webui/options/options_ui.cc b/chrome/browser/ui/webui/options/options_ui.cc

index 917f0992828c97de6b61a184bfd993e4350f6551..f4033eb38383b0cd9bf88cdb4c9aabd0a0ca3234 100644

--- a/chrome/browser/ui/webui/options/options_ui.cc

+++ b/chrome/browser/ui/webui/options/options_ui.cc

@@ -129,17 +129,17 @@ class OptionsUIHTMLSource : public content::URLDataSource {

explicit OptionsUIHTMLSource(base::DictionaryValue* localized_strings);

// content::URLDataSource implementation.

- virtual std::string GetSource() const override;

- virtual void StartDataRequest(

+ std::string GetSource() const override;

+ void StartDataRequest(

const std::string& path,

int render_process_id,

int render_frame_id,

const content::URLDataSource::GotDataCallback& callback) override;

- virtual std::string GetMimeType(const std::string&) const override;

- virtual bool ShouldDenyXFrameOptions() const override;

+ std::string GetMimeType(const std::string&) const override;

+ bool ShouldDenyXFrameOptions() const override;

private:

- virtual ~OptionsUIHTMLSource();

+ ~OptionsUIHTMLSource() override;

// Localized strings collection.

scoped_ptr<base::DictionaryValue> localized_strings_;