chrome/browser/ui/webui/options/options_ui_browsertest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_ui_browsertest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/options/options_ui.cc ('k') | chrome/browser/ui/webui/options/password_manager_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/options_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/options/options_ui_browsertest.cc b/chrome/browser/ui/webui/options/options_ui_browsertest.cc

index 395c53f4c5f447b8ac4ed317c032b20e5ead02a0..6b3ecafe4635f1cb1d57dea827c7c791f3e87c4f 100644

--- a/chrome/browser/ui/webui/options/options_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/options/options_ui_browsertest.cc

@@ -56,7 +56,7 @@ class SignOutWaiter : public SigninManagerBase::Observer {

: seen_(false), running_(false), scoped_observer_(this) {

scoped_observer_.Add(signin_manager);

}

- virtual ~SignOutWaiter() {}

+ ~SignOutWaiter() override {}

void Wait() {

if (seen_)

@@ -68,8 +68,8 @@ class SignOutWaiter : public SigninManagerBase::Observer {

EXPECT_TRUE(seen_);

}

- virtual void GoogleSignedOut(const std::string& account_id,

- const std::string& username) override {

+ void GoogleSignedOut(const std::string& account_id,

+ const std::string& username) override {

seen_ = true;

if (!running_)

return;