chrome/browser/ui/tabs/tab_strip_model.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/tabs/tab_menu_model.h ('k') | chrome/browser/ui/tabs/tab_strip_model_order_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tabs/tab_strip_model.cc

diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc

index b5492214c77e54de2755bcbf9f80ff55c8a32ecd..5fa230a0174e3ee1b4c84045ade31f89bf38709b 100644

--- a/chrome/browser/ui/tabs/tab_strip_model.cc

+++ b/chrome/browser/ui/tabs/tab_strip_model.cc

@@ -71,7 +71,7 @@ class CloseTracker {

private:

// WebContentsObserver:

- virtual void WebContentsDestroyed() override {

+ void WebContentsDestroyed() override {

parent_->OnWebContentsDestroyed(this);

}

@@ -159,7 +159,7 @@ class TabStripModel::WebContentsData : public content::WebContentsObserver {

private:

// Make sure that if someone deletes this WebContents out from under us, it

// is properly removed from the tab strip.

- virtual void WebContentsDestroyed() override;

+ void WebContentsDestroyed() override;

// The WebContents being tracked by this WebContentsData. The

// WebContentsObserver does keep a reference, but when the WebContents is