chrome/browser/ui/tabs/tab_strip_model_order_controller.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_order_controller.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/tabs/tab_strip_model.cc ('k') | chrome/browser/ui/tabs/tab_strip_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tabs/tab_strip_model_order_controller.h

diff --git a/chrome/browser/ui/tabs/tab_strip_model_order_controller.h b/chrome/browser/ui/tabs/tab_strip_model_order_controller.h

index 5f7f20eed01acb1b9089462c8f12e6a9d71a3b4d..5bb15b622503f018feaec0e005ddd7f65aa4ecb6 100644

--- a/chrome/browser/ui/tabs/tab_strip_model_order_controller.h

+++ b/chrome/browser/ui/tabs/tab_strip_model_order_controller.h

@@ -17,7 +17,7 @@

class TabStripModelOrderController : public TabStripModelObserver {

public:

explicit TabStripModelOrderController(TabStripModel* tabstrip);

- virtual ~TabStripModelOrderController();

+ ~TabStripModelOrderController() override;

// Determine where to place a newly opened tab by using the supplied

// transition and foreground flag to figure out how it was opened.

@@ -28,10 +28,10 @@ class TabStripModelOrderController : public TabStripModelObserver {

int DetermineNewSelectedIndex(int removed_index) const;

// Overridden from TabStripModelObserver:

- virtual void ActiveTabChanged(content::WebContents* old_contents,

- content::WebContents* new_contents,

- int index,

- int reason) override;

+ void ActiveTabChanged(content::WebContents* old_contents,

+ content::WebContents* new_contents,

+ int index,

+ int reason) override;

private:

// Returns a valid index to be selected after the tab at |removing_index| is