chrome/browser/ui/browser_instant_controller.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_instant_controller.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/browser_focus_uitest.cc ('k') | chrome/browser/ui/browser_instant_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_instant_controller.h

diff --git a/chrome/browser/ui/browser_instant_controller.h b/chrome/browser/ui/browser_instant_controller.h

index 1402bfb0d38d290fb997473e8771acd1c1835d05..6e35ae9b76a0ce9b9ade48148b9f95cc4adb0f66 100644

--- a/chrome/browser/ui/browser_instant_controller.h

+++ b/chrome/browser/ui/browser_instant_controller.h

@@ -25,7 +25,7 @@ class BrowserInstantController : public SearchModelObserver,

public InstantServiceObserver {

public:

explicit BrowserInstantController(Browser* browser);

- virtual ~BrowserInstantController();

+ ~BrowserInstantController() override;

// Commits the current Instant, returning true on success. This is intended

// for use from OpenCurrentURL.

@@ -49,11 +49,11 @@ class BrowserInstantController : public SearchModelObserver,

private:

// SearchModelObserver:

- virtual void ModelChanged(const SearchModel::State& old_state,

- const SearchModel::State& new_state) override;

+ void ModelChanged(const SearchModel::State& old_state,

+ const SearchModel::State& new_state) override;

// InstantServiceObserver:

- virtual void DefaultSearchProviderChanged() override;

+ void DefaultSearchProviderChanged() override;

// Replaces the contents at tab |index| with |new_contents| and deletes the

// existing contents.