chrome/browser/ui/browser_focus_uitest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_focus_uitest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/browser_content_translate_driver_observer.h ('k') | chrome/browser/ui/browser_instant_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_focus_uitest.cc

diff --git a/chrome/browser/ui/browser_focus_uitest.cc b/chrome/browser/ui/browser_focus_uitest.cc

index cdc1f4da9d55d31494d174395bc7bca65e124122..df397b939ba6786c9e05143bf7e1033f4a8aa799 100644

--- a/chrome/browser/ui/browser_focus_uitest.cc

+++ b/chrome/browser/ui/browser_focus_uitest.cc

@@ -65,7 +65,7 @@ const char kTypicalPage[] = "/focus/typical_page.html";

class BrowserFocusTest : public InProcessBrowserTest {

public:

// InProcessBrowserTest overrides:

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

}

@@ -169,7 +169,7 @@ class TestInterstitialPage : public content::InterstitialPageDelegate {

EXPECT_TRUE(tab->ShowingInterstitialPage());

}

- virtual std::string GetHTMLContents() override { return html_contents_; }

+ std::string GetHTMLContents() override { return html_contents_; }

RenderViewHost* render_view_host() {

return interstitial_page_->GetRenderViewHostForTesting();