Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
index e16773626e36fe1f959e83ae3b30ce519a496dd8..a3fb759753b5f0d9c274f29c57fb37e4b34023e7 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
@@ -49,10 +49,10 @@ class AutofillPopupControllerImpl : public AutofillPopupController {
// Hides the popup and destroys the controller. This also invalidates
// |delegate_|.
- virtual void Hide() override;
+ void Hide() override;
// Invoked when the view was destroyed by by someone other than this class.
- virtual void ViewDestroyed() override;
+ void ViewDestroyed() override;
bool HandleKeyPressEvent(const content::NativeWebKeyboardEvent& event);
@@ -70,35 +70,33 @@ class AutofillPopupControllerImpl : public AutofillPopupController {
gfx::NativeView container_view,
const gfx::RectF& element_bounds,
base::i18n::TextDirection text_direction);
- virtual ~AutofillPopupControllerImpl();
+ ~AutofillPopupControllerImpl() override;
// AutofillPopupController implementation.
- virtual void UpdateBoundsAndRedrawPopup() override;
- virtual void SetSelectionAtPoint(const gfx::Point& point) override;
- virtual bool AcceptSelectedLine() override;
- virtual void SelectionCleared() override;
- virtual void AcceptSuggestion(size_t index) override;
- virtual int GetIconResourceID(
- const base::string16& resource_name) const override;
- virtual bool CanDelete(size_t index) const override;
- virtual bool IsWarning(size_t index) const override;
- virtual gfx::Rect GetRowBounds(size_t index) override;
- virtual void SetPopupBounds(const gfx::Rect& bounds) override;
- virtual const gfx::Rect& popup_bounds() const override;
- virtual gfx::NativeView container_view() override;
- virtual const gfx::RectF& element_bounds() const override;
- virtual bool IsRTL() const override;
-
- virtual const std::vector<base::string16>& names() const override;
- virtual const std::vector<base::string16>& subtexts() const override;
- virtual const std::vector<base::string16>& icons() const override;
- virtual const std::vector<int>& identifiers() const override;
+ void UpdateBoundsAndRedrawPopup() override;
+ void SetSelectionAtPoint(const gfx::Point& point) override;
+ bool AcceptSelectedLine() override;
+ void SelectionCleared() override;
+ void AcceptSuggestion(size_t index) override;
+ int GetIconResourceID(const base::string16& resource_name) const override;
+ bool CanDelete(size_t index) const override;
+ bool IsWarning(size_t index) const override;
+ gfx::Rect GetRowBounds(size_t index) override;
+ void SetPopupBounds(const gfx::Rect& bounds) override;
+ const gfx::Rect& popup_bounds() const override;
+ gfx::NativeView container_view() override;
+ const gfx::RectF& element_bounds() const override;
+ bool IsRTL() const override;
+
+ const std::vector<base::string16>& names() const override;
+ const std::vector<base::string16>& subtexts() const override;
+ const std::vector<base::string16>& icons() const override;
+ const std::vector<int>& identifiers() const override;
#if !defined(OS_ANDROID)
- virtual const gfx::FontList& GetNameFontListForRow(
- size_t index) const override;
- virtual const gfx::FontList& subtext_font_list() const override;
+ const gfx::FontList& GetNameFontListForRow(size_t index) const override;
+ const gfx::FontList& subtext_font_list() const override;
#endif
- virtual int selected_line() const override;
+ int selected_line() const override;
content::WebContents* web_contents();

Powered by Google App Engine
This is Rietveld 408576698