Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7277)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc
index d2893044b82cf0d3a68f653ebbda918de2b4a252..a55168bfd3d1db56864698606c79144458581a34 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc
@@ -28,15 +28,15 @@ class TestAutofillExternalDelegate : public AutofillExternalDelegate {
AutofillDriver* autofill_driver)
: AutofillExternalDelegate(autofill_manager, autofill_driver),
popup_hidden_(true) {}
- virtual ~TestAutofillExternalDelegate() {}
+ ~TestAutofillExternalDelegate() override {}
- virtual void OnPopupShown() override {
+ void OnPopupShown() override {
popup_hidden_ = false;
AutofillExternalDelegate::OnPopupShown();
}
- virtual void OnPopupHidden() override {
+ void OnPopupHidden() override {
popup_hidden_ = true;
if (message_loop_runner_.get())
@@ -71,7 +71,7 @@ class AutofillPopupControllerBrowserTest
AutofillPopupControllerBrowserTest() {}
virtual ~AutofillPopupControllerBrowserTest() {}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(web_contents != NULL);
@@ -88,9 +88,7 @@ class AutofillPopupControllerBrowserTest
// Normally the WebContents will automatically delete the delegate, but here
// the delegate is owned by this test, so we have to manually destroy.
- virtual void WebContentsDestroyed() override {
- autofill_external_delegate_.reset();
- }
+ void WebContentsDestroyed() override { autofill_external_delegate_.reset(); }
protected:
scoped_ptr<TestAutofillExternalDelegate> autofill_external_delegate_;

Powered by Google App Engine
This is Rietveld 408576698