chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc ('k') | chrome/browser/ui/autofill/test_generated_credit_card_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h

diff --git a/chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h b/chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h

index 3f3af79be238fc5960665746e33c825e7e4c3b52..16358bb4841fd56f29a294f94e3e36b6900e7b91 100644

--- a/chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h

+++ b/chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h

@@ -18,7 +18,7 @@ class TestGeneratedCreditCardBubbleController

public:

explicit TestGeneratedCreditCardBubbleController(

content::WebContents* contents);

- virtual ~TestGeneratedCreditCardBubbleController();

+ ~TestGeneratedCreditCardBubbleController() override;

// Whether this controller is installed on |web_contents()|.

bool IsInstalled() const;

@@ -34,10 +34,10 @@ class TestGeneratedCreditCardBubbleController

protected:

// GeneratedCreditCardBubbleController:

- virtual base::WeakPtr<GeneratedCreditCardBubbleView> CreateBubble() override;

- virtual bool CanShow() const override;

- virtual void SetupAndShow(const base::string16& fronting_card_name,

- const base::string16& backing_card_name) override;

+ base::WeakPtr<GeneratedCreditCardBubbleView> CreateBubble() override;

+ bool CanShow() const override;

+ void SetupAndShow(const base::string16& fronting_card_name,

+ const base::string16& backing_card_name) override;

private:

// How many bubbles have been shown via this controller.