chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/autofill/password_generation_popup_controller_impl.h ('k') | chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc b/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

index 4e1c1185cafd5c14733acb409ebe7f1e7f9a70cc..67bcc377e27217a1112380285041d3b7ef7aa1ff 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

@@ -30,7 +30,7 @@ class TestPasswordGenerationPopupController :

web_contents,

native_view) {}

- virtual ~TestPasswordGenerationPopupController() {}

+ ~TestPasswordGenerationPopupController() override {}

PasswordGenerationPopupView* view() {

return view_;

@@ -39,7 +39,7 @@ class TestPasswordGenerationPopupController :

class PasswordGenerationPopupViewTest : public InProcessBrowserTest {

public:

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

gfx::NativeView native_view =

browser()->tab_strip_model()->GetActiveWebContents()->GetNativeView();