chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/extensions/extension_view_mac.h ('k') | chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h

diff --git a/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h b/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h

index af4b80b1b1e6db970765d3b70da01a5ea1be4a51..3fe80cc07b78906219cc83c5e13410ea48660a22 100644

--- a/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h

+++ b/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h

@@ -32,7 +32,7 @@ class MediaGalleriesDialogCocoa : public ConstrainedWindowMacDelegate,

MediaGalleriesDialogCocoa(

MediaGalleriesDialogController* controller,

MediaGalleriesCocoaController* delegate);

- virtual ~MediaGalleriesDialogCocoa();

+ ~MediaGalleriesDialogCocoa() override;

// Called when the user clicks the accept button.

void OnAcceptClicked();

@@ -42,17 +42,15 @@ class MediaGalleriesDialogCocoa : public ConstrainedWindowMacDelegate,

void OnAuxiliaryButtonClicked();

// MediaGalleriesDialog implementation:

- virtual void UpdateGalleries() override;

+ void UpdateGalleries() override;

// ConstrainedWindowMacDelegate implementation.

- virtual void OnConstrainedWindowClosed(

- ConstrainedWindowMac* window) override;

+ void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override;

// MediaGalleryListEntryController implementation.

- virtual void OnCheckboxToggled(MediaGalleryPrefId pref_id,

- bool checked) override;

- virtual void OnFolderViewerClicked(MediaGalleryPrefId prefId) override;

- virtual ui::MenuModel* GetContextMenu(MediaGalleryPrefId pref_id) override;

+ void OnCheckboxToggled(MediaGalleryPrefId pref_id, bool checked) override;

+ void OnFolderViewerClicked(MediaGalleryPrefId prefId) override;

+ ui::MenuModel* GetContextMenu(MediaGalleryPrefId pref_id) override;

private:

FRIEND_TEST_ALL_PREFIXES(MediaGalleriesDialogBrowserTest, Close);

@@ -62,7 +60,7 @@ class MediaGalleriesDialogCocoa : public ConstrainedWindowMacDelegate,

FRIEND_TEST_ALL_PREFIXES(MediaGalleriesDialogTest, ForgetDeletes);

// MediaGalleriesDialog implementation:

- virtual void AcceptDialogForTesting() override;

+ void AcceptDialogForTesting() override;

void InitDialogControls();

CGFloat CreateCheckboxes(