chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h ('k') | chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

diff --git a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

index 700a9d8dfa344adf63f4d4d82b2a3b44f6abb7e4..92903792bad21d893d1d2d9e0f2448745aaf4f83 100644

--- a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

+++ b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h

@@ -25,15 +25,15 @@ class WindowedInstallDialogController

const ExtensionInstallPrompt::ShowParams& show_params,

ExtensionInstallPrompt::Delegate* delegate,

scoped_refptr<ExtensionInstallPrompt::Prompt> prompt);

- virtual ~WindowedInstallDialogController();

+ ~WindowedInstallDialogController() override;

// Invoked by the -[NSWindow windowWillClose:] notification after a dialog

// choice is invoked. Releases owned resources, then deletes |this|.

void OnWindowClosing();

// ExtensionInstallPrompt::Delegate:

- virtual void InstallUIProceed() override;

- virtual void InstallUIAbort(bool user_initiated) override;

+ void InstallUIProceed() override;

+ void InstallUIAbort(bool user_initiated) override;

private:

FRIEND_TEST_ALL_PREFIXES(WindowedInstallDialogControllerBrowserTest,