chrome/browser/ui/panels/base_panel_browser_test.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/panels/base_panel_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/base_panel_browser_test.h

diff --git a/chrome/browser/ui/panels/base_panel_browser_test.h b/chrome/browser/ui/panels/base_panel_browser_test.h

index f99eb476f3d834752931258beb4df367f189b51f..619a34ef8d936f7c00f9696d5e9e26ce6a61a17d 100644

--- a/chrome/browser/ui/panels/base_panel_browser_test.h

+++ b/chrome/browser/ui/panels/base_panel_browser_test.h

@@ -23,7 +23,7 @@ class BasePanelBrowserTest : public InProcessBrowserTest {

class MockDisplaySettingsProvider : public DisplaySettingsProvider {

public:

MockDisplaySettingsProvider() { }

- virtual ~MockDisplaySettingsProvider() { }

+ ~MockDisplaySettingsProvider() override {}

virtual void SetPrimaryDisplay(

const gfx::Rect& display_area, const gfx::Rect& work_area) = 0;

@@ -42,8 +42,8 @@ class BasePanelBrowserTest : public InProcessBrowserTest {

BasePanelBrowserTest();

virtual ~BasePanelBrowserTest();

- virtual void SetUpCommandLine(base::CommandLine* command_line) override;

- virtual void SetUpOnMainThread() override;

+ void SetUpCommandLine(base::CommandLine* command_line) override;

+ void SetUpOnMainThread() override;

protected:

enum ActiveState { SHOW_AS_ACTIVE, SHOW_AS_INACTIVE };