chrome/browser/ui/omnibox/omnibox_view_browsertest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/omnibox/omnibox_navigation_observer.h ('k') | chrome/browser/ui/panels/base_panel_browser_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

index fa609f9d8faa2776ed7d0e8ecd7d91fc179f7685..227ddac1ca0cd905aae90b067082223808d1ccb5 100644

--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

@@ -139,7 +139,7 @@ const int kCtrlOrCmdMask = ui::EF_CONTROL_DOWN;

class OmniboxViewTest : public InProcessBrowserTest,

public content::NotificationObserver {

protected:

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));

ASSERT_NO_FATAL_FAILURE(SetupComponents());

chrome::FocusLocationBar(browser());

@@ -339,9 +339,9 @@ class OmniboxViewTest : public InProcessBrowserTest,

ASSERT_NO_FATAL_FAILURE(SetupHistory());

}

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override {

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override {

switch (type) {

case content::NOTIFICATION_WEB_CONTENTS_DESTROYED:

case chrome::NOTIFICATION_TAB_PARENTED: