Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
diff --git a/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm b/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
index 42598b6f82a77691bca8463cbae7d0eaa196f9ed..a924f157b0ae8d797c113655c6a3c73ffccf96b5 100644
--- a/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
+++ b/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
@@ -32,7 +32,7 @@ class ConstrainedWebDialogDelegateMac
: ConstrainedWebDialogDelegateBase(browser_context, delegate, NULL) {}
// WebDialogWebContentsDelegate interface.
- virtual void CloseContents(WebContents* source) override {
+ void CloseContents(WebContents* source) override {
window_->CloseWebContentsModalDialog();
}
@@ -57,32 +57,28 @@ class ConstrainedWebDialogDelegateViewMac :
content::BrowserContext* browser_context,
WebDialogDelegate* delegate,
content::WebContents* web_contents);
- virtual ~ConstrainedWebDialogDelegateViewMac() {}
+ ~ConstrainedWebDialogDelegateViewMac() override {}
// ConstrainedWebDialogDelegate interface
- virtual const WebDialogDelegate*
- GetWebDialogDelegate() const override {
+ const WebDialogDelegate* GetWebDialogDelegate() const override {
return impl_->GetWebDialogDelegate();
}
- virtual WebDialogDelegate* GetWebDialogDelegate() override {
+ WebDialogDelegate* GetWebDialogDelegate() override {
return impl_->GetWebDialogDelegate();
}
- virtual void OnDialogCloseFromWebUI() override {
+ void OnDialogCloseFromWebUI() override {
return impl_->OnDialogCloseFromWebUI();
}
- virtual void ReleaseWebContentsOnDialogClose() override {
+ void ReleaseWebContentsOnDialogClose() override {
return impl_->ReleaseWebContentsOnDialogClose();
}
- virtual NativeWebContentsModalDialog GetNativeDialog() override {
+ NativeWebContentsModalDialog GetNativeDialog() override {
return constrained_window_->GetNativeDialog();
}
- virtual WebContents* GetWebContents() override {
- return impl_->GetWebContents();
- }
+ WebContents* GetWebContents() override { return impl_->GetWebContents(); }
// ConstrainedWindowMacDelegate interface
- virtual void OnConstrainedWindowClosed(
- ConstrainedWindowMac* window) override {
+ void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override {
if (!impl_->closed_via_webui())
GetWebDialogDelegate()->OnDialogClosed("");
delete this;

Powered by Google App Engine
This is Rietveld 408576698