chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/command_observer_bridge.h ('k') | chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm

index 9b17587862075034ec59f4132eef5a7d200f9430..962f5827d8474c9ab6e805aceae84d3c9d0abfeb 100644

--- a/chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm

@@ -25,16 +25,16 @@ class TestConfirmBubbleModel : public ConfirmBubbleModel {

bool* cancel_clicked,

bool* link_clicked);

TestConfirmBubbleModel();

- virtual ~TestConfirmBubbleModel() override;

- virtual base::string16 GetTitle() const override;

- virtual base::string16 GetMessageText() const override;

- virtual gfx::Image* GetIcon() const override;

- virtual int GetButtons() const override;

- virtual base::string16 GetButtonLabel(BubbleButton button) const override;

- virtual void Accept() override;

- virtual void Cancel() override;

- virtual base::string16 GetLinkText() const override;

- virtual void LinkClicked() override;

+ ~TestConfirmBubbleModel() override;

+ base::string16 GetTitle() const override;

+ base::string16 GetMessageText() const override;

+ gfx::Image* GetIcon() const override;

+ int GetButtons() const override;

+ base::string16 GetButtonLabel(BubbleButton button) const override;

+ void Accept() override;

+ void Cancel() override;

+ base::string16 GetLinkText() const override;

+ void LinkClicked() override;

private:

bool* model_deleted_;