chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/bookmarks/bookmark_browsertest.cc ('k') | chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h

diff --git a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h

index 34354846a4609b3eaf74fd99ecf25cef40749082..e14bea5c73967bea455114f9e00fa7f2f7679766 100644

--- a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h

+++ b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h

@@ -22,13 +22,13 @@ class BookmarkBubbleSignInDelegate : public BookmarkBubbleDelegate,

explicit BookmarkBubbleSignInDelegate(Browser* browser);

private:

- virtual ~BookmarkBubbleSignInDelegate();

+ ~BookmarkBubbleSignInDelegate() override;

// BookmarkBubbleDelegate:

- virtual void OnSignInLinkClicked() override;

+ void OnSignInLinkClicked() override;

// chrome::BrowserListObserver:

- virtual void OnBrowserRemoved(Browser* browser) override;

+ void OnBrowserRemoved(Browser* browser) override;

// Makes sure |browser_| points to a valid browser.

void EnsureBrowser();