chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h ('k') | chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc

index 87e199c92e8a7cc7be1716640582f2ae27950156..b7e9770e3c1f0a154b72894866a8e314f4bde558 100644

--- a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc

@@ -34,9 +34,7 @@ class BookmarkBubbleSignInDelegateTest : public BrowserWithTestWindowTest {

private:

// TestBrowserWindow:

- virtual void Show() override {

- ++show_count_;

- }

+ void Show() override { ++show_count_; }

// Number of times that the Show() method has been called.

int show_count_;

@@ -44,9 +42,7 @@ class BookmarkBubbleSignInDelegateTest : public BrowserWithTestWindowTest {

DISALLOW_COPY_AND_ASSIGN(Window);

};

- virtual BrowserWindow* CreateBrowserWindow() override {

- return new Window();

- }

+ BrowserWindow* CreateBrowserWindow() override { return new Window(); }

private:

DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleSignInDelegateTest);