chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/task_manager_mac_unittest.mm ('k') | chrome/browser/ui/cocoa/toolbar/wrench_toolbar_button_cell.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

index 1f7f383f3a7b1aed730d79ce073ac69b6bf10c83..f6100a3698c4dfea23891e8c115600e1f3a44091 100644

--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

@@ -109,16 +109,15 @@ class NotificationBridge : public WrenchMenuBadgeController::Delegate {

: controller_(controller),

badge_controller_([controller browser]->profile(), this) {

}

- virtual ~NotificationBridge() {

- }

+ ~NotificationBridge() override {}

void UpdateBadgeSeverity() {

badge_controller_.UpdateDelegate();

}

- virtual void UpdateBadgeSeverity(WrenchMenuBadgeController::BadgeType type,

- WrenchIconPainter::Severity severity,

- bool animate) override {

+ void UpdateBadgeSeverity(WrenchMenuBadgeController::BadgeType type,

+ WrenchIconPainter::Severity severity,

+ bool animate) override {

[controller_ updateWrenchButtonSeverity:severity animate:animate];

}