Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2968)

Unified Diff: chrome/browser/ui/cocoa/task_manager_mac_unittest.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/task_manager_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/task_manager_mac_unittest.mm b/chrome/browser/ui/cocoa/task_manager_mac_unittest.mm
index 590cf876eaf1a8c386c77c697e214d44bfa1b84c..11919305bd0d1e67ccff85c437b6b6685d7a1a07 100644
--- a/chrome/browser/ui/cocoa/task_manager_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/task_manager_mac_unittest.mm
@@ -21,21 +21,19 @@ class TestResource : public task_manager::Resource {
public:
TestResource(const base::string16& title, pid_t pid)
: title_(title), pid_(pid) {}
- virtual base::string16 GetTitle() const override { return title_; }
- virtual base::string16 GetProfileName() const override {
- return base::string16();
- }
- virtual gfx::ImageSkia GetIcon() const override { return gfx::ImageSkia(); }
- virtual base::ProcessHandle GetProcess() const override { return pid_; }
- virtual int GetUniqueChildProcessId() const override {
+ base::string16 GetTitle() const override { return title_; }
+ base::string16 GetProfileName() const override { return base::string16(); }
+ gfx::ImageSkia GetIcon() const override { return gfx::ImageSkia(); }
+ base::ProcessHandle GetProcess() const override { return pid_; }
+ int GetUniqueChildProcessId() const override {
// In reality the unique child process ID is not the actual process ID,
// but for testing purposes it shouldn't make difference.
return static_cast<int>(base::GetCurrentProcId());
}
- virtual Type GetType() const override { return RENDERER; }
- virtual bool SupportNetworkUsage() const override { return false; }
- virtual void SetSupportNetworkUsage() override { NOTREACHED(); }
- virtual void Refresh() override {}
+ Type GetType() const override { return RENDERER; }
+ bool SupportNetworkUsage() const override { return false; }
+ void SetSupportNetworkUsage() override { NOTREACHED(); }
+ void Refresh() override {}
base::string16 title_;
base::string16 profile_name_;
pid_t pid_;

Powered by Google App Engine
This is Rietveld 408576698