chrome/browser/ui/prefs/prefs_tab_helper.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/prefs/prefs_tab_helper.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/passwords/save_password_refusal_combobox_model.h ('k') | chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/prefs/prefs_tab_helper.h

diff --git a/chrome/browser/ui/prefs/prefs_tab_helper.h b/chrome/browser/ui/prefs/prefs_tab_helper.h

index 502e217c89f63fe6fe88d277a5281fb87a11a81c..60c98e4d6d61f247daa2c6b2a51399cefff0099e 100644

--- a/chrome/browser/ui/prefs/prefs_tab_helper.h

+++ b/chrome/browser/ui/prefs/prefs_tab_helper.h

@@ -30,7 +30,7 @@ class PrefRegistrySyncable;

class PrefsTabHelper : public content::NotificationObserver,

public content::WebContentsUserData<PrefsTabHelper> {

public:

- virtual ~PrefsTabHelper();

+ ~PrefsTabHelper() override;

static void InitIncognitoUserPrefStore(OverlayUserPrefStore* pref_store);

static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

@@ -44,9 +44,9 @@ class PrefsTabHelper : public content::NotificationObserver,

friend class content::WebContentsUserData<PrefsTabHelper>;

// content::NotificationObserver overrides:

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// Update the WebContents's RendererPreferences.

void UpdateRendererPreferences();