Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
index dcdeedf7c453ad2acf0dfcda68c075b7b7732fb6..3236754ac400b423a01d3564fc08f9e4b71a6535 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
@@ -52,14 +52,14 @@ class TestRecentTabsSubMenuModel : public RecentTabsSubMenuModel {
}
// Testing overrides to ui::SimpleMenuModel::Delegate:
- virtual bool IsCommandIdEnabled(int command_id) const override {
+ bool IsCommandIdEnabled(int command_id) const override {
bool val = RecentTabsSubMenuModel::IsCommandIdEnabled(command_id);
if (val)
++enable_count_;
return val;
}
- virtual void ExecuteCommand(int command_id, int event_flags) override {
+ void ExecuteCommand(int command_id, int event_flags) override {
++execute_count_;
}
@@ -81,18 +81,15 @@ class TestRecentTabsMenuModelDelegate : public ui::MenuModelDelegate {
model_->SetMenuModelDelegate(this);
}
- virtual ~TestRecentTabsMenuModelDelegate() {
+ ~TestRecentTabsMenuModelDelegate() override {
model_->SetMenuModelDelegate(NULL);
}
// ui::MenuModelDelegate implementation:
- virtual void OnIconChanged(int index) override {
- }
+ void OnIconChanged(int index) override {}
- virtual void OnMenuStructureChanged() override {
- got_changes_ = true;
- }
+ void OnMenuStructureChanged() override { got_changes_ = true; }
bool got_changes() const { return got_changes_; }
@@ -105,10 +102,10 @@ class TestRecentTabsMenuModelDelegate : public ui::MenuModelDelegate {
class DummyRouter : public browser_sync::LocalSessionEventRouter {
public:
- virtual ~DummyRouter() {}
- virtual void StartRoutingTo(
+ ~DummyRouter() override {}
+ void StartRoutingTo(
browser_sync::LocalSessionEventHandler* handler) override {}
- virtual void Stop() override {}
+ void Stop() override {}
};
} // namespace

Powered by Google App Engine
This is Rietveld 408576698