chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h ('k') | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

index 90b3a79b926e3d6aad7d0a3c41b581f4b39bbad2..b1eb408b87bcf53e3eee013755a353e488facd51 100644

--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

@@ -56,16 +56,15 @@ class RecentTabsSubMenuModel : public ui::SimpleMenuModel,

RecentTabsSubMenuModel(ui::AcceleratorProvider* accelerator_provider,

Browser* browser,

browser_sync::OpenTabsUIDelegate* open_tabs_delegate);

- virtual ~RecentTabsSubMenuModel();

+ ~RecentTabsSubMenuModel() override;

// Overridden from ui::SimpleMenuModel::Delegate:

- virtual bool IsCommandIdChecked(int command_id) const override;

- virtual bool IsCommandIdEnabled(int command_id) const override;

- virtual bool GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) override;

- virtual void ExecuteCommand(int command_id, int event_flags) override;

- virtual const gfx::FontList* GetLabelFontListAt(int index) const override;

+ bool IsCommandIdChecked(int command_id) const override;

+ bool IsCommandIdEnabled(int command_id) const override;

+ bool GetAcceleratorForCommandId(int command_id,

+ ui::Accelerator* accelerator) override;

+ void ExecuteCommand(int command_id, int event_flags) override;

+ const gfx::FontList* GetLabelFontListAt(int index) const override;

int GetMaxWidthForItemAtIndex(int item_index) const;

bool GetURLAndTitleForItemAtIndex(int index,

@@ -131,8 +130,8 @@ class RecentTabsSubMenuModel : public ui::SimpleMenuModel,

browser_sync::OpenTabsUIDelegate* GetOpenTabsUIDelegate();

// Overridden from TabRestoreServiceObserver:

- virtual void TabRestoreServiceChanged(TabRestoreService* service) override;

- virtual void TabRestoreServiceDestroyed(TabRestoreService* service) override;

+ void TabRestoreServiceChanged(TabRestoreService* service) override;

+ void TabRestoreServiceDestroyed(TabRestoreService* service) override;

Browser* browser_; // Weak.