Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2167)

Unified Diff: chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm b/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm
index 6c8fc34e3ff336df0943fe0055dee6c534e06708..5d025f6c8f6e5d865c7591cc6d5070712107f76d 100644
--- a/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm
+++ b/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm
@@ -19,36 +19,30 @@ class NativeWebContentsModalDialogManagerCocoa
: dialog_(dialog) {
}
- virtual ~NativeWebContentsModalDialogManagerCocoa() {
- }
+ ~NativeWebContentsModalDialogManagerCocoa() override {}
// SingleWebContentsDialogManager overrides
- virtual void Show() override {
+ void Show() override {
GetConstrainedWindowMac(dialog())->ShowWebContentsModalDialog();
}
- virtual void Hide() override {
- }
+ void Hide() override {}
- virtual void Close() override {
+ void Close() override {
GetConstrainedWindowMac(dialog())->CloseWebContentsModalDialog();
}
- virtual void Focus() override {
+ void Focus() override {
GetConstrainedWindowMac(dialog())->FocusWebContentsModalDialog();
}
- virtual void Pulse() override {
+ void Pulse() override {
GetConstrainedWindowMac(dialog())->PulseWebContentsModalDialog();
}
- virtual void HostChanged(
- web_modal::WebContentsModalDialogHost* new_host) override {
- }
+ void HostChanged(web_modal::WebContentsModalDialogHost* new_host) override {}
- virtual NativeWebContentsModalDialog dialog() override {
- return dialog_;
- }
+ NativeWebContentsModalDialog dialog() override { return dialog_; }
private:
static ConstrainedWindowMac* GetConstrainedWindowMac(

Powered by Google App Engine
This is Rietveld 408576698