chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

index 38dc78d075c545f4abb88dcb8bd22b8b791ab169..ef43064e58e5edc8052121cc326c06467e890b6c 100644

--- a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

@@ -162,11 +162,9 @@ class ValidationMessageBubbleCocoa : public chrome::ValidationMessageBubble {

subText:sub_text] retain]);

}

- virtual ~ValidationMessageBubbleCocoa() {

- [controller_.get() close];

- }

+ ~ValidationMessageBubbleCocoa() override { [controller_.get() close]; }

- virtual void SetPositionRelativeToAnchor(

+ void SetPositionRelativeToAnchor(

content::RenderWidgetHost* widget_host,

const gfx::Rect& anchor_in_root_view) override {

[controller_.get()