Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2336)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index b4341f010cb4f546bb5e0c499bd34d7e7601aa1d..f1e9de93dcc9ed8c11d7139799212c06fcf68178 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -117,18 +117,18 @@ class ConfirmEmailDialogDelegate : public TabModalConfirmDialogDelegate {
const std::string& last_email,
const std::string& email,
Callback callback);
- virtual ~ConfirmEmailDialogDelegate();
+ ~ConfirmEmailDialogDelegate() override;
// TabModalConfirmDialogDelegate:
- virtual base::string16 GetTitle() override;
- virtual base::string16 GetDialogMessage() override;
- virtual base::string16 GetAcceptButtonTitle() override;
- virtual base::string16 GetCancelButtonTitle() override;
- virtual base::string16 GetLinkText() const override;
- virtual void OnAccepted() override;
- virtual void OnCanceled() override;
- virtual void OnClosed() override;
- virtual void OnLinkClicked(WindowOpenDisposition disposition) override;
+ base::string16 GetTitle() override;
+ base::string16 GetDialogMessage() override;
+ base::string16 GetAcceptButtonTitle() override;
+ base::string16 GetCancelButtonTitle() override;
+ base::string16 GetLinkText() const override;
+ void OnAccepted() override;
+ void OnCanceled() override;
+ void OnClosed() override;
+ void OnLinkClicked(WindowOpenDisposition disposition) override;
std::string last_email_;
std::string email_;
@@ -429,11 +429,11 @@ std::string GetSigninScopedDeviceId(Profile* profile) {
class CurrentHistoryCleaner : public content::WebContentsObserver {
public:
explicit CurrentHistoryCleaner(content::WebContents* contents);
- virtual ~CurrentHistoryCleaner();
+ ~CurrentHistoryCleaner() override;
// content::WebContentsObserver:
- virtual void WebContentsDestroyed() override;
- virtual void DidCommitProvisionalLoadForFrame(
+ void WebContentsDestroyed() override;
+ void DidCommitProvisionalLoadForFrame(
content::RenderFrameHost* render_frame_host,
const GURL& url,
ui::PageTransition transition_type) override;

Powered by Google App Engine
This is Rietveld 408576698