Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4495)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.h
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.h b/chrome/browser/ui/sync/one_click_signin_helper.h
index 90c448ff8f5bed880e12ceca6bbb822f2d649cc8..c80816daeefee41633964e724f58589ed08145ad 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.h
+++ b/chrome/browser/ui/sync/one_click_signin_helper.h
@@ -133,7 +133,7 @@ class OneClickSigninHelper
SyncStarterWrapper(
const OneClickSigninHelper::StartSyncArgs& args,
OneClickSigninSyncStarter::StartSyncMode start_mode);
- virtual ~SyncStarterWrapper();
+ ~SyncStarterWrapper() override;
void Start();
@@ -150,15 +150,15 @@ class OneClickSigninHelper
const std::string& refresh_token);
// Overriden from SigninOAuthHelper::Consumer.
- virtual void OnSigninOAuthInformationAvailable(
+ void OnSigninOAuthInformationAvailable(
const std::string& email,
const std::string& display_email,
const std::string& refresh_token) override;
- virtual void OnSigninOAuthInformationFailure(
+ void OnSigninOAuthInformationFailure(
const GoogleServiceAuthError& error) override;
// Overriden from chrome::BrowserListObserver.
- virtual void OnBrowserRemoved(Browser* browser) override;
+ void OnBrowserRemoved(Browser* browser) override;
OneClickSigninHelper::StartSyncArgs args_;
chrome::HostDesktopType desktop_type_;
@@ -285,7 +285,7 @@ class OneClickSigninHelper
OneClickSigninHelper(content::WebContents* web_contents,
password_manager::PasswordManager* password_manager);
- virtual ~OneClickSigninHelper();
+ ~OneClickSigninHelper() override;
// Returns true if the one-click signin feature can be offered at this time.
// It can be offered if the io_data is not in an incognito window and if the
@@ -332,14 +332,13 @@ class OneClickSigninHelper
void PasswordSubmitted(const autofill::PasswordForm& form);
// content::WebContentsObserver overrides.
- virtual void DidStartNavigationToPendingEntry(
+ void DidStartNavigationToPendingEntry(
const GURL& url,
content::NavigationController::ReloadType reload_type) override;
- virtual void DidNavigateMainFrame(
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
- virtual void DidStopLoading(
- content::RenderViewHost* render_view_host) override;
+ void DidStopLoading(content::RenderViewHost* render_view_host) override;
OneClickSigninSyncStarter::Callback CreateSyncStarterCallback();

Powered by Google App Engine
This is Rietveld 408576698