Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/ui/global_error/global_error_service_browsertest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/global_error/global_error_service_browsertest.cc
diff --git a/chrome/browser/ui/global_error/global_error_service_browsertest.cc b/chrome/browser/ui/global_error/global_error_service_browsertest.cc
index 4c63f836bd70211913c6f451456e5e04f32f3695..7c4f9be4ca4646bf84595e2d1e462104877cd28d 100644
--- a/chrome/browser/ui/global_error/global_error_service_browsertest.cc
+++ b/chrome/browser/ui/global_error/global_error_service_browsertest.cc
@@ -21,36 +21,34 @@ class BubbleViewError : public GlobalErrorWithStandardBubble {
int bubble_view_close_count() { return bubble_view_close_count_; }
- virtual bool HasMenuItem() override { return false; }
- virtual int MenuItemCommandID() override {
+ bool HasMenuItem() override { return false; }
+ int MenuItemCommandID() override {
ADD_FAILURE();
return 0;
}
- virtual base::string16 MenuItemLabel() override {
+ base::string16 MenuItemLabel() override {
ADD_FAILURE();
return base::string16();
}
- virtual void ExecuteMenuItem(Browser* browser) override { ADD_FAILURE(); }
+ void ExecuteMenuItem(Browser* browser) override { ADD_FAILURE(); }
- virtual bool HasBubbleView() override { return true; }
- virtual base::string16 GetBubbleViewTitle() override {
- return base::string16();
- }
- virtual std::vector<base::string16> GetBubbleViewMessages() override {
+ bool HasBubbleView() override { return true; }
+ base::string16 GetBubbleViewTitle() override { return base::string16(); }
+ std::vector<base::string16> GetBubbleViewMessages() override {
return std::vector<base::string16>();
}
- virtual base::string16 GetBubbleViewAcceptButtonLabel() override {
+ base::string16 GetBubbleViewAcceptButtonLabel() override {
return base::string16();
}
- virtual base::string16 GetBubbleViewCancelButtonLabel() override {
+ base::string16 GetBubbleViewCancelButtonLabel() override {
return base::string16();
}
- virtual void OnBubbleViewDidClose(Browser* browser) override {
+ void OnBubbleViewDidClose(Browser* browser) override {
EXPECT_TRUE(browser);
++bubble_view_close_count_;
}
- virtual void BubbleViewAcceptButtonPressed(Browser* browser) override {}
- virtual void BubbleViewCancelButtonPressed(Browser* browser) override {}
+ void BubbleViewAcceptButtonPressed(Browser* browser) override {}
+ void BubbleViewCancelButtonPressed(Browser* browser) override {}
private:
int bubble_view_close_count_;

Powered by Google App Engine
This is Rietveld 408576698