chrome/browser/ui/global_error/global_error_service_factory.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/global_error/global_error_service_factory.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/global_error/global_error_service_browsertest.cc ('k') | chrome/browser/ui/global_error/global_error_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/global_error/global_error_service_factory.h

diff --git a/chrome/browser/ui/global_error/global_error_service_factory.h b/chrome/browser/ui/global_error/global_error_service_factory.h

index 53f19d1d0a7dec68cf160f3da12b7d2b903bc264..a1a8834df6523d3e662c7671d4500da85411fa08 100644

--- a/chrome/browser/ui/global_error/global_error_service_factory.h

+++ b/chrome/browser/ui/global_error/global_error_service_factory.h

@@ -26,12 +26,12 @@ class GlobalErrorServiceFactory : public BrowserContextKeyedServiceFactory {

friend struct DefaultSingletonTraits<GlobalErrorServiceFactory>;

GlobalErrorServiceFactory();

- virtual ~GlobalErrorServiceFactory();

+ ~GlobalErrorServiceFactory() override;

// BrowserContextKeyedServiceFactory:

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* profile) const override;

- virtual content::BrowserContext* GetBrowserContextToUse(

+ content::BrowserContext* GetBrowserContextToUse(

content::BrowserContext* context) const override;

DISALLOW_COPY_AND_ASSIGN(GlobalErrorServiceFactory);