chrome/browser/ui/webui/chrome_web_ui_controller_factory.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/chrome_web_contents_handler.h ('k') | chrome/browser/ui/webui/components_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

index e7f0dad1c930fc5a985d605c35d37c5b134bb5a0..5db4e6e3cf398ca96d4d2e00fe85195cf89bc299 100644

--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

@@ -20,14 +20,13 @@ class RefCountedMemory;

class ChromeWebUIControllerFactory : public content::WebUIControllerFactory {

public:

- virtual content::WebUI::TypeID GetWebUIType(

- content::BrowserContext* browser_context,

- const GURL& url) const override;

- virtual bool UseWebUIForURL(content::BrowserContext* browser_context,

- const GURL& url) const override;

- virtual bool UseWebUIBindingsForURL(content::BrowserContext* browser_context,

+ content::WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context,

const GURL& url) const override;

- virtual content::WebUIController* CreateWebUIControllerForURL(

+ bool UseWebUIForURL(content::BrowserContext* browser_context,

+ const GURL& url) const override;

+ bool UseWebUIBindingsForURL(content::BrowserContext* browser_context,

+ const GURL& url) const override;

+ content::WebUIController* CreateWebUIControllerForURL(

content::WebUI* web_ui,

const GURL& url) const override;

@@ -43,7 +42,7 @@ class ChromeWebUIControllerFactory : public content::WebUIControllerFactory {

protected:

ChromeWebUIControllerFactory();

- virtual ~ChromeWebUIControllerFactory();

+ ~ChromeWebUIControllerFactory() override;

private:

friend struct DefaultSingletonTraits<ChromeWebUIControllerFactory>;