Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_
6 #define CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_ 6 #define CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "components/favicon_base/favicon_callback.h" 10 #include "components/favicon_base/favicon_callback.h"
11 #include "content/public/browser/web_ui.h" 11 #include "content/public/browser/web_ui.h"
12 #include "content/public/browser/web_ui_controller_factory.h" 12 #include "content/public/browser/web_ui_controller_factory.h"
13 #include "ui/base/layout.h" 13 #include "ui/base/layout.h"
14 14
15 class Profile; 15 class Profile;
16 16
17 namespace base { 17 namespace base {
18 class RefCountedMemory; 18 class RefCountedMemory;
19 } 19 }
20 20
21 class ChromeWebUIControllerFactory : public content::WebUIControllerFactory { 21 class ChromeWebUIControllerFactory : public content::WebUIControllerFactory {
22 public: 22 public:
23 virtual content::WebUI::TypeID GetWebUIType( 23 content::WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context,
24 content::BrowserContext* browser_context, 24 const GURL& url) const override;
25 const GURL& url) const override; 25 bool UseWebUIForURL(content::BrowserContext* browser_context,
26 virtual bool UseWebUIForURL(content::BrowserContext* browser_context, 26 const GURL& url) const override;
27 bool UseWebUIBindingsForURL(content::BrowserContext* browser_context,
27 const GURL& url) const override; 28 const GURL& url) const override;
28 virtual bool UseWebUIBindingsForURL(content::BrowserContext* browser_context, 29 content::WebUIController* CreateWebUIControllerForURL(
29 const GURL& url) const override;
30 virtual content::WebUIController* CreateWebUIControllerForURL(
31 content::WebUI* web_ui, 30 content::WebUI* web_ui,
32 const GURL& url) const override; 31 const GURL& url) const override;
33 32
34 // Get the favicon for |page_url| and run |callback| with result when loaded. 33 // Get the favicon for |page_url| and run |callback| with result when loaded.
35 // Note. |callback| is always run asynchronously. 34 // Note. |callback| is always run asynchronously.
36 void GetFaviconForURL( 35 void GetFaviconForURL(
37 Profile* profile, 36 Profile* profile,
38 const GURL& page_url, 37 const GURL& page_url,
39 const std::vector<int>& desired_sizes_in_pixel, 38 const std::vector<int>& desired_sizes_in_pixel,
40 const favicon_base::FaviconResultsCallback& callback) const; 39 const favicon_base::FaviconResultsCallback& callback) const;
41 40
42 static ChromeWebUIControllerFactory* GetInstance(); 41 static ChromeWebUIControllerFactory* GetInstance();
43 42
44 protected: 43 protected:
45 ChromeWebUIControllerFactory(); 44 ChromeWebUIControllerFactory();
46 virtual ~ChromeWebUIControllerFactory(); 45 ~ChromeWebUIControllerFactory() override;
47 46
48 private: 47 private:
49 friend struct DefaultSingletonTraits<ChromeWebUIControllerFactory>; 48 friend struct DefaultSingletonTraits<ChromeWebUIControllerFactory>;
50 49
51 // Gets the data for the favicon for a WebUI page. Returns NULL if the WebUI 50 // Gets the data for the favicon for a WebUI page. Returns NULL if the WebUI
52 // does not have a favicon. 51 // does not have a favicon.
53 // The returned favicon data must be 52 // The returned favicon data must be
54 // |gfx::kFaviconSize| x |gfx::kFaviconSize| DIP. GetFaviconForURL() should 53 // |gfx::kFaviconSize| x |gfx::kFaviconSize| DIP. GetFaviconForURL() should
55 // be updated if this changes. 54 // be updated if this changes.
56 base::RefCountedMemory* GetFaviconResourceBytes( 55 base::RefCountedMemory* GetFaviconResourceBytes(
57 const GURL& page_url, ui::ScaleFactor scale_factor) const; 56 const GURL& page_url, ui::ScaleFactor scale_factor) const;
58 57
59 DISALLOW_COPY_AND_ASSIGN(ChromeWebUIControllerFactory); 58 DISALLOW_COPY_AND_ASSIGN(ChromeWebUIControllerFactory);
60 }; 59 };
61 60
62 #endif // CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_ 61 #endif // CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698