Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3068)

Unified Diff: chrome/browser/ui/webui/favicon_source.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/favicon_source.h
diff --git a/chrome/browser/ui/webui/favicon_source.h b/chrome/browser/ui/webui/favicon_source.h
index 5d678d81ff0d0295f1baeaad990e949c42cb85bc..e4a8fe9503601cd7b2d59f53c41704da3aabb752 100644
--- a/chrome/browser/ui/webui/favicon_source.h
+++ b/chrome/browser/ui/webui/favicon_source.h
@@ -68,19 +68,18 @@ class FaviconSource : public content::URLDataSource {
// |type| is the type of icon this FaviconSource will provide.
FaviconSource(Profile* profile, IconType type);
- virtual ~FaviconSource();
+ ~FaviconSource() override;
// content::URLDataSource implementation.
- virtual std::string GetSource() const override;
- virtual void StartDataRequest(
+ std::string GetSource() const override;
+ void StartDataRequest(
const std::string& path,
int render_process_id,
int render_frame_id,
const content::URLDataSource::GotDataCallback& callback) override;
- virtual std::string GetMimeType(const std::string&) const override;
- virtual bool ShouldReplaceExistingSource() const override;
- virtual bool ShouldServiceRequest(
- const net::URLRequest* request) const override;
+ std::string GetMimeType(const std::string&) const override;
+ bool ShouldReplaceExistingSource() const override;
+ bool ShouldServiceRequest(const net::URLRequest* request) const override;
protected:
struct IconRequest {

Powered by Google App Engine
This is Rietveld 408576698