Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 6713084: Move the rest of the renderer->browser messages that belong in content. Also do a bunch of cleanup: (Closed)

Created:
9 years, 9 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, jam, Paweł Hajdan Jr., kkania, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, native-client-reviews_googlegroups.com, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move the rest of the renderer->browser messages that belong in content. Also do a bunch of cleanup: -move safe browsing messages together -get rid of webkit_param_traits and common_param_trait since they're no longer needed -remove the multiple include of IPC files from places that don't need it TBR=tsepez Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79235

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 4

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+656 lines, -1581 lines) Patch
M chrome/browser/accessibility/browser_accessibility_manager.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/accessibility/browser_accessibility_manager_mac.mm View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/accessibility/browser_accessibility_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/accessibility/browser_accessibility_manager_win.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/accessibility/browser_accessibility_win_unittest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 2 3 4 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/autofill_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/automation_messages.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/automation_messages.cc View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/common_message_generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/common_param_traits.h View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/common/common_param_traits.cc View 1 chunk +0 lines, -224 lines 0 comments Download
M chrome/common/common_param_traits_unittest.cc View 1 2 3 2 chunks +0 lines, -79 lines 0 comments Download
M chrome/common/devtools_messages.h View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/common/devtools_messages.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/common/nacl_messages.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/render_messages.h View 16 chunks +108 lines, -283 lines 0 comments Download
M chrome/common/render_messages.cc View 2 chunks +17 lines, -89 lines 0 comments Download
M chrome/common/render_messages_params.h View 2 chunks +0 lines, -82 lines 0 comments Download
M chrome/common/render_messages_params.cc View 4 chunks +0 lines, -118 lines 0 comments Download
D chrome/common/render_messages_unittest.cc View 1 2 3 1 chunk +0 lines, -108 lines 0 comments Download
M chrome/common/safebrowsing_messages.h View 1 chunk +36 lines, -3 lines 0 comments Download
M chrome/common/utility_messages.h View 3 chunks +10 lines, -12 lines 0 comments Download
D chrome/common/webkit_param_traits.h View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/common/webkit_param_traits.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper_linux.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details.h View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details.cc View 5 chunks +14 lines, -15 lines 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc View 1 2 3 6 chunks +37 lines, -37 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/ipclist/all_messages.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome_frame/cfproxy_support.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/cfproxy_test.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/child_process_messages.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/child_thread.cc View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/content_message_generator.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 9 chunks +295 lines, -38 lines 0 comments Download
M content/renderer/command_buffer_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitclient_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years, 9 months ago (2011-03-24 00:36:12 UTC) #1
Tom Sepez
LGTM. The compiler and linker will catch more stuff than I can manually. http://codereview.chromium.org/6713084/diff/7091/chrome/common/automation_messages.cc File ...
9 years, 9 months ago (2011-03-24 00:51:21 UTC) #2
jam
http://codereview.chromium.org/6713084/diff/7091/chrome/common/automation_messages.cc File chrome/common/automation_messages.cc (right): http://codereview.chromium.org/6713084/diff/7091/chrome/common/automation_messages.cc#newcode680 chrome/common/automation_messages.cc:680: // The traits for these are defined in render_messages.h ...
9 years, 9 months ago (2011-03-24 01:07:56 UTC) #3
Tom Sepez
9 years, 9 months ago (2011-03-24 01:12:17 UTC) #4
I think a common_param_traits.h that uses macros and can be multiply included is
exactly what we want here.

Powered by Google App Engine
This is Rietveld 408576698